Bug 46795

Summary: build still broken since r68521
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, alex, darin, gustavo, mrobinson, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed build fix
none
proposed proper fix none

Philippe Normand
Reported 2010-09-29 03:58:04 PDT
Martin did an attempt to fix it with r68550 but it still fails.
Attachments
proposed build fix (1.84 KB, patch)
2010-09-29 04:00 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
proposed proper fix (2.68 KB, patch)
2010-09-29 10:34 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-09-29 04:00:38 PDT
Created attachment 69175 [details] proposed build fix
Philippe Normand
Comment 2 2010-09-29 08:13:28 PDT
Commited http://trac.webkit.org/changeset/68645 after discussion on IRC with kov, Ossy and bbandix. Leaving opened for now.
Csaba Osztrogonác
Comment 3 2010-09-29 10:34:52 PDT
Created attachment 69211 [details] proposed proper fix I think the landed patch is incorrect: foo1.c: foo2.c: dependency1.c dependency2.c receipe_to_make_foo1_and_foo2 --> Here "foo1.c:" is an empty rule and we don't want this.
Darin Adler
Comment 4 2010-09-29 10:40:12 PDT
(In reply to comment #3) > I think the landed patch is incorrect: > > foo1.c: > foo2.c: dependency1.c dependency2.c > receipe_to_make_foo1_and_foo2 > > --> Here "foo1.c:" is an empty rule and we don't want this. Yes, I agree.
Andras Becsi
Comment 5 2010-09-30 02:04:42 PDT
(In reply to comment #3) > Created an attachment (id=69211) [details] > proposed proper fix LGTM. With the empty rule we have the same effect as without Martin's patch. Thanks for fixing this.
Martin Robinson
Comment 6 2010-09-30 08:38:11 PDT
Comment on attachment 69211 [details] proposed proper fix Thank you!
Csaba Osztrogonác
Comment 7 2010-09-30 08:45:52 PDT
Comment on attachment 69211 [details] proposed proper fix Clearing flags on attachment: 69211 Committed r68787: <http://trac.webkit.org/changeset/68787>
Csaba Osztrogonác
Comment 8 2010-09-30 08:46:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.