Bug 46789

Summary: Web Inspector: assign the resourceLoad finish time which was obtained from the network stack as the end time for the corresponding event in Timeline.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[patch] First iteration. none

Ilya Tikhonovsky
Reported 2010-09-29 00:51:49 PDT
See related change for Resources panel https://bugs.webkit.org/show_bug.cgi?id=45664
Attachments
[patch] First iteration. (3.72 KB, patch)
2010-09-29 00:56 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2010-09-29 00:56:18 PDT
Created attachment 69168 [details] [patch] First iteration.
Yury Semikhatsky
Comment 2 2010-09-29 01:03:27 PDT
Comment on attachment 69168 [details] [patch] First iteration. View in context: https://bugs.webkit.org/attachment.cgi?id=69168&action=review > WebCore/inspector/InspectorTimelineAgent.cpp:248 > + RefPtr<InspectorObject> record = TimelineRecordFactory::createGenericRecord(finishTime ? finishTime : WTF::currentTimeMS()); I don't quite understand why we not use finishTime in all cases?
Ilya Tikhonovsky
Comment 3 2010-09-30 05:48:45 PDT
Committed r68779 M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorTimelineAgent.cpp M WebCore/inspector/InspectorTimelineAgent.h r68779 = 28059cde085c595f4c6f4c8c40d411ba472717db (refs/remotes/trunk)
Note You need to log in before you can comment on or make changes to this bug.