Bug 46788

Summary: check for ENABLE(GLIB_SUPPORT) in WebView
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch
none
proposed patch none

Philippe Normand
Reported 2010-09-29 00:50:15 PDT
WebView.mm contains a small runloop observer used to trigger the main glib context iterations. That code is guarded with ENABLE(VIDEO) && USE(GSTREAMER). It would make more sense to guard it with ENABLE(GLIB_SUPPORT) instead because it's not specific to video or gstreamer support in the end.
Attachments
proposed patch (2.64 KB, patch)
2010-09-29 00:54 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
proposed patch (3.69 KB, patch)
2010-09-29 05:37 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-09-29 00:54:09 PDT
Created attachment 69167 [details] proposed patch
Philippe Normand
Comment 2 2010-09-29 05:37:04 PDT
Created attachment 69181 [details] proposed patch
Martin Robinson
Comment 3 2010-10-02 11:24:06 PDT
Comment on attachment 69181 [details] proposed patch Looks reasonable!
WebKit Commit Bot
Comment 4 2010-10-05 08:32:39 PDT
Comment on attachment 69181 [details] proposed patch Clearing flags on attachment: 69181 Committed r69109: <http://trac.webkit.org/changeset/69109>
WebKit Commit Bot
Comment 5 2010-10-05 08:32:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.