| Summary: | Bundle should expose a reportException method | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||
| Component: | WebKit2 | Assignee: | Jessie Berlin <jberlin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | jberlin, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Jessie Berlin
2010-09-28 17:06:28 PDT
Created attachment 70023 [details]
Add InjectedBundle::reportException
Comment on attachment 70023 [details] Add InjectedBundle::reportException View in context: https://bugs.webkit.org/attachment.cgi?id=70023&action=review > WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:232 > + // Make sure the context has a DOMWindow global object, otherwise this context didn't originate from a View. I'm not sure if View with a capital V refers to a class or a named concept. Maybe this comment could be improved. (In reply to comment #3) > (From update of attachment 70023 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70023&action=review > > > WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:232 > > + // Make sure the context has a DOMWindow global object, otherwise this context didn't originate from a View. > > I'm not sure if View with a capital V refers to a class or a named concept. Maybe this comment could be improved. You are right, when we are talking in WebKit2 terms that should be a Page. In WebKit1 terms that is a WebView. I will correct the comment. Thanks for the review! Jessie Comment on attachment 70023 [details] Add InjectedBundle::reportException Comitted in r69309 http://trac.webkit.org/changeset/69309 |