Bug 46749

Summary: Web Inspector: a number of breakpoints for one line
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch. pfeldman: review+, podivilov: commit-queue-

Description Ilya Tikhonovsky 2010-09-28 13:16:36 PDT
1) start chromium
2) open inspector
3) press pause
4) move mouse over inspected page
5) debugger will stop on mouseover listener
6) make a breakpoint
7) close inspector
8) open inspector

expected:
single breakpoint

actual:
multiple breakpoints for one line.
Comment 1 Pavel Podivilov 2010-10-04 03:40:47 PDT
Created attachment 69612 [details]
Proposed patch.
Comment 2 Joseph Pecoraro 2010-10-04 09:40:34 PDT
Comment on attachment 69612 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=69612&action=review

> WebCore/bindings/v8/DebuggerScript.js:103
> +    if (!locations.length)
> +      return undefined;
> +    var actualLineNumber = locations[0].line;

Looks like incorrect whitespace on the 2nd line. Would be great if this was fixed.
Comment 3 Pavel Podivilov 2010-10-04 10:01:35 PDT
Committed r69019: <http://trac.webkit.org/changeset/69019>
Comment 4 Pavel Podivilov 2010-10-04 10:03:11 PDT
(In reply to comment #2)
> (From update of attachment 69612 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69612&action=review
> 
> > WebCore/bindings/v8/DebuggerScript.js:103
> > +    if (!locations.length)
> > +      return undefined;
> > +    var actualLineNumber = locations[0].line;
> 
> Looks like incorrect whitespace on the 2nd line. Would be great if this was fixed.

Sure, thanks for correction, Joe!
Comment 5 Joseph Pecoraro 2010-10-04 10:27:45 PDT
(In reply to comment #4)
> Sure, thanks for correction, Joe!

Thanks for making the fix and landing manually!