Bug 46744

Summary: [Qt] Text drawing taints GraphicsContext's QPainter::pen()
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch kenneth: review+

Andreas Kling
Reported 2010-09-28 12:03:28 PDT
Drawing text currently replaces the GC's pen. This means that using canvas's strokeText() will make the canvas context's strokeStyle lose sync with the GC's pen.
Attachments
Proposed patch (5.88 KB, patch)
2010-09-28 12:04 PDT, Andreas Kling 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-09-28 12:04:57 PDT
Created attachment 69082 [details] Proposed patch
Kenneth Rohde Christiansen
Comment 2 2010-09-28 12:07:21 PDT
Comment on attachment 69082 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=69082&action=review LGTM > WebCore/platform/graphics/qt/FontQt.cpp:212 > + QPen oldPen = p->pen(); Persoannly I like previousPen better than old.
Andreas Kling
Comment 3 2010-09-28 12:19:59 PDT
Committed r68549: <http://trac.webkit.org/changeset/68549>
WebKit Review Bot
Comment 4 2010-09-28 12:56:55 PDT
http://trac.webkit.org/changeset/68549 might have broken SnowLeopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.