Bug 46739

Summary: Vertical scroll bar on apple.com is too short with WebKit2
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
darin: review-
Updated patch hyatt: review+

Sam Weinig
Reported 2010-09-28 11:08:48 PDT
Vertical scroll bar on apple.com is too short with WebKit2.
Attachments
Patch (16.63 KB, patch)
2010-09-28 11:13 PDT, Sam Weinig 		darin: review-
DetailsFormatted DiffDiff
Updated patch (16.33 KB, patch)
2010-09-28 12:59 PDT, Sam Weinig 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-09-28 11:09:09 PDT
<rdar://problem/8379230>
Sam Weinig
Comment 2 2010-09-28 11:13:58 PDT
Created attachment 69074 [details] Patch
Darin Adler
Comment 3 2010-09-28 11:26:33 PDT
Comment on attachment 69074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69074&action=review review- because there is no reason to handle only the top two levels of FrameView. > WebKit2/UIProcess/API/mac/WKView.mm:323 > + // Temporarily enable the resize indicator to make a the _ownsWindowGrowBox > + // calculation work. Comment should go on one line. > WebKit2/WebProcess/WebPage/WebPage.cpp:578 > + const HashSet<RefPtr<Widget> >* viewChildren = view->children(); Why do we need to do this one level deep, and not multiple levels? Might be better to use the frame tree and walk all the frames, not just the top level subframes. > WebKit2/WebProcess/WebPage/WebPage.cpp:583 > + static_cast<FrameView*>(widget)->invalidateScrollbars(); The “invalidate” terminology here seems unclear to me.
Sam Weinig
Comment 4 2010-09-28 12:59:59 PDT
Created attachment 69091 [details] Updated patch
Sam Weinig
Comment 5 2010-09-28 13:31:21 PDT
Landed in r68557.
Note You need to log in before you can comment on or make changes to this bug.