Bug 46739 – Vertical scroll bar on apple.com is too short with WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sam Weinig]

Vertical scroll bar on apple.com is too short with WebKit2.

[Sam Weinig]

<rdar://problem/8379230>

[Sam Weinig]

Created attachment 69074 [details]
Patch

[Darin Adler]

Comment on attachment 69074 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69074&action=review

review- because there is no reason to handle only the top two levels of FrameView.

> WebKit2/UIProcess/API/mac/WKView.mm:323
> +    // Temporarily enable the resize indicator to make a the _ownsWindowGrowBox
> +    // calculation work.

Comment should go on one line.

> WebKit2/WebProcess/WebPage/WebPage.cpp:578
> +    const HashSet<RefPtr<Widget> >* viewChildren = view->children();

Why do we need to do this one level deep, and not multiple levels? Might be better to use the frame tree and walk all the frames, not just the top level subframes.

> WebKit2/WebProcess/WebPage/WebPage.cpp:583
> +            static_cast<FrameView*>(widget)->invalidateScrollbars();

The “invalidate” terminology here seems unclear to me.

[Sam Weinig]

Created attachment 69091 [details]
Updated patch

[Sam Weinig]

Landed in r68557.