Bug 46730

Summary:

[Qt] Clean up QWebPage::ViewportConfiguration API

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebKit Qt

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ademar, eric, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch (r=kenneth)	none

Andreas Kling

Reported 2010-09-28 09:17:22 PDT

- Pass QSize parameter as const-reference - Style fixes

Attachments
Patch (r=kenneth) (2.95 KB, patch) 2010-09-28 09:18 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2010-09-28 09:18:03 PDT

Created attachment 69060 [details] Patch (r=kenneth)

Andreas Kling

Comment 2 2010-09-28 09:21:05 PDT

Comment on attachment 69060 [details] Patch (r=kenneth) Clearing flags on attachment: 69060 Committed r68525: <http://trac.webkit.org/changeset/68525>

Andreas Kling

Comment 3 2010-09-28 09:21:15 PDT

All reviewed patches have been landed. Closing bug.

Ademar Reis

Comment 4 2010-09-28 10:03:20 PDT

Revision r68525 cherry-picked into qtwebkit-2.1 with commit 9615fdd <http://gitorious.org/webkit/qtwebkit/commit/9615fdd>

WebKit Review Bot

Comment 5 2010-09-28 10:11:09 PDT

Note You need to log in before you can comment on or make changes to this bug.