WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
46730
[Qt] Clean up QWebPage::ViewportConfiguration API
https://bugs.webkit.org/show_bug.cgi?id=46730
Summary
[Qt] Clean up QWebPage::ViewportConfiguration API
Andreas Kling
Reported
2010-09-28 09:17:22 PDT
- Pass QSize parameter as const-reference - Style fixes
Attachments
Patch (r=kenneth)
(2.95 KB, patch)
2010-09-28 09:18 PDT
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2010-09-28 09:18:03 PDT
Created
attachment 69060
[details]
Patch (r=kenneth)
Andreas Kling
Comment 2
2010-09-28 09:21:05 PDT
Comment on
attachment 69060
[details]
Patch (r=kenneth) Clearing flags on attachment: 69060 Committed
r68525
: <
http://trac.webkit.org/changeset/68525
>
Andreas Kling
Comment 3
2010-09-28 09:21:15 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 4
2010-09-28 10:03:20 PDT
Revision
r68525
cherry-picked into qtwebkit-2.1 with commit 9615fdd <
http://gitorious.org/webkit/qtwebkit/commit/9615fdd
>
WebKit Review Bot
Comment 5
2010-09-28 10:11:09 PDT
http://trac.webkit.org/changeset/68525
might have broken Qt Windows 32-bit Debug The following changes are on the blame list:
http://trac.webkit.org/changeset/68523
http://trac.webkit.org/changeset/68524
http://trac.webkit.org/changeset/68525
http://trac.webkit.org/changeset/68526
http://trac.webkit.org/changeset/68527
http://trac.webkit.org/changeset/68528
http://trac.webkit.org/changeset/68529
http://trac.webkit.org/changeset/68530
http://trac.webkit.org/changeset/68531
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug