Bug 46718

Summary:

[Qt] Remove support for Qt 4.5

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

WebKit Qt

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

commit-queue, kling

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
First patch, for WebCore	none
WebKit's support	none
For WebKit 2	none
For WebKitTools	none

Benjamin Poulain

Reported 2010-09-28 05:33:14 PDT

With the release of Qt 4.7, we no longer support antique Qt versions ;) We can remove all the check for QT_VERSION_CHECK(4, 6, 0) in order to clean the code.

Attachments
First patch, for WebCore (5.57 KB, patch) 2010-09-28 06:52 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
WebKit's support (25.02 KB, patch) 2010-09-28 06:58 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
For WebKit 2 (2.75 KB, patch) 2010-09-28 07:08 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
For WebKitTools (12.38 KB, patch) 2010-09-28 07:13 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2010-09-28 06:52:03 PDT

Created attachment 69042 [details] First patch, for WebCore

Benjamin Poulain

Comment 2 2010-09-28 06:58:25 PDT

Created attachment 69044 [details] WebKit's support

WebKit Commit Bot

Comment 3 2010-09-28 07:03:11 PDT

Comment on attachment 69044 [details] WebKit's support Rejecting patch 69044 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 69044]" exit_code: 2 Cleaning working directory Updating working directory Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=69044&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=46718&ctype=xml Processing 1 patch from 1 bug. Processing patch 69044 from bug 46718. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4021180

Andreas Kling

Comment 4 2010-09-28 07:07:47 PDT

Comment on attachment 69044 [details] WebKit's support Er, what? Let's try again.

Benjamin Poulain

Comment 5 2010-09-28 07:08:13 PDT

Created attachment 69046 [details] For WebKit 2

WebKit Commit Bot

Comment 6 2010-09-28 07:09:32 PDT

Comment on attachment 69042 [details] First patch, for WebCore Clearing flags on attachment: 69042 Committed r68510: <http://trac.webkit.org/changeset/68510>

Benjamin Poulain

Comment 7 2010-09-28 07:13:35 PDT

Created attachment 69047 [details] For WebKitTools

WebKit Commit Bot

Comment 8 2010-09-28 07:23:23 PDT

Comment on attachment 69046 [details] For WebKit 2 Clearing flags on attachment: 69046 Committed r68512: <http://trac.webkit.org/changeset/68512>

WebKit Commit Bot

Comment 9 2010-09-28 07:40:50 PDT

Comment on attachment 69047 [details] For WebKitTools Clearing flags on attachment: 69047 Committed r68514: <http://trac.webkit.org/changeset/68514>

WebKit Commit Bot

Comment 10 2010-09-28 08:03:39 PDT

Comment on attachment 69044 [details] WebKit's support Rejecting patch 69044 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 69044]" exit_code: 2 Cleaning working directory Updating working directory Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=69044&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=46718&ctype=xml Processing 1 patch from 1 bug. Processing patch 69044 from bug 46718. Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4074139

Andreas Kling

Comment 11 2010-09-28 08:10:02 PDT

Committed r68517: <http://trac.webkit.org/changeset/68517>

Andreas Kling

Comment 12 2010-09-28 08:10:36 PDT

Comment on attachment 69044 [details] WebKit's support Landed manually in <http://trac.webkit.org/changeset/68517>

Note You need to log in before you can comment on or make changes to this bug.