Bug 46718 - [Qt] Remove support for Qt 4.5
Summary: [Qt] Remove support for Qt 4.5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Trivial
Assignee: Benjamin Poulain
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-09-28 05:33 PDT by Benjamin Poulain
Modified: 2010-09-28 08:10 PDT (History)
2 users (show)

See Also:

Attachments
First patch, for WebCore (5.57 KB, patch)
2010-09-28 06:52 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
WebKit's support (25.02 KB, patch)
2010-09-28 06:58 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
For WebKit 2 (2.75 KB, patch)
2010-09-28 07:08 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
For WebKitTools (12.38 KB, patch)
2010-09-28 07:13 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2010-09-28 05:33:14 PDT 
With the release of Qt 4.7, we no longer support antique Qt versions ;)

We can remove all the check for QT_VERSION_CHECK(4, 6, 0) in order to clean the code.
Comment 1 Benjamin Poulain 2010-09-28 06:52:03 PDT 
Created attachment 69042 [details]
First patch, for WebCore
Comment 2 Benjamin Poulain 2010-09-28 06:58:25 PDT 
Created attachment 69044 [details]
WebKit's support
Comment 3 WebKit Commit Bot 2010-09-28 07:03:11 PDT 
Comment on attachment 69044 [details]
WebKit's support

Rejecting patch 69044 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 69044]" exit_code: 2
Cleaning working directory
Updating working directory
Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=69044&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=46718&ctype=xml
Processing 1 patch from 1 bug.
Processing patch 69044 from bug 46718.
Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4021180
Comment 4 Andreas Kling 2010-09-28 07:07:47 PDT 
Comment on attachment 69044 [details]
WebKit's support

Er, what? Let's try again.
Comment 5 Benjamin Poulain 2010-09-28 07:08:13 PDT 
Created attachment 69046 [details]
For WebKit 2
Comment 6 WebKit Commit Bot 2010-09-28 07:09:32 PDT 
Comment on attachment 69042 [details]
First patch, for WebCore

Clearing flags on attachment: 69042

Committed r68510: <http://trac.webkit.org/changeset/68510>
Comment 7 Benjamin Poulain 2010-09-28 07:13:35 PDT 
Created attachment 69047 [details]
For WebKitTools
Comment 8 WebKit Commit Bot 2010-09-28 07:23:23 PDT 
Comment on attachment 69046 [details]
For WebKit 2

Clearing flags on attachment: 69046

Committed r68512: <http://trac.webkit.org/changeset/68512>
Comment 9 WebKit Commit Bot 2010-09-28 07:40:50 PDT 
Comment on attachment 69047 [details]
For WebKitTools

Clearing flags on attachment: 69047

Committed r68514: <http://trac.webkit.org/changeset/68514>
Comment 10 WebKit Commit Bot 2010-09-28 08:03:39 PDT 
Comment on attachment 69044 [details]
WebKit's support

Rejecting patch 69044 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 69044]" exit_code: 2
Cleaning working directory
Updating working directory
Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=69044&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=46718&ctype=xml
Processing 1 patch from 1 bug.
Processing patch 69044 from bug 46718.
Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4074139
Comment 11 Andreas Kling 2010-09-28 08:10:02 PDT 
Committed r68517: <http://trac.webkit.org/changeset/68517>
Comment 12 Andreas Kling 2010-09-28 08:10:36 PDT 
Comment on attachment 69044 [details]
WebKit's support

Landed manually in <http://trac.webkit.org/changeset/68517>