Bug 46702

Summary: Remove unnecessary cacheFlush calls from Thumb-2
Product: WebKit Reporter: Gabor Loki <loki>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: barraclough, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
Remove unnecessary cacheFlush calls from Thumb-2 none

Gabor Loki
Reported 2010-09-28 00:35:33 PDT
There are several redundant cacheFlush calls in Thumb-2 JIT.
Attachments
Remove unnecessary cacheFlush calls from Thumb-2 (2.21 KB, patch)
2010-09-28 00:42 PDT, Gabor Loki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Loki
Comment 1 2010-09-28 00:42:37 PDT
Created attachment 69029 [details] Remove unnecessary cacheFlush calls from Thumb-2 The setPointer function calls setInt32 which calls cacheFlush on the corresponding instructions. So, there is no need for a second cacheFlush on the same address range. SunSpider: 1.007x as fast V8: 1.017x as fast
Csaba Osztrogonác
Comment 2 2010-09-30 01:02:02 PDT
Comment on attachment 69029 [details] Remove unnecessary cacheFlush calls from Thumb-2 LGTM, r=me.
WebKit Commit Bot
Comment 3 2010-09-30 01:37:39 PDT
Comment on attachment 69029 [details] Remove unnecessary cacheFlush calls from Thumb-2 Clearing flags on attachment: 69029 Committed r68764: <http://trac.webkit.org/changeset/68764>
WebKit Commit Bot
Comment 4 2010-09-30 01:37:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.