Bug 46670

Summary: check-webkit-style should check for explicit constructors.
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED INVALID    
Severity: Minor CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

David Levin
Reported 2010-09-27 16:08:04 PDT
Based on this thread: https://lists.webkit.org/pipermail/webkit-dev/2010-May/012873.html
Attachments
Patch (5.17 KB, patch)
2010-09-27 16:11 PDT, David Levin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2010-09-27 16:11:46 PDT
Created attachment 68987 [details] Patch
Darin Adler
Comment 2 2010-09-27 16:15:51 PDT
Comment on attachment 68987 [details] Patch This doesn’t seem like a style rule to me.
David Levin
Comment 3 2010-09-27 16:24:43 PDT
(In reply to comment #2) > (From update of attachment 68987 [details]) > This doesn’t seem like a style rule to me. So you don't believe that this should be flagged in general. I've noticed some folks noting this in reviews for patches, and in general it seems like a good practice to mark single argument constructors as explicit unless there is a good reason to do otherwise. It seemed in keeping with this comment: https://lists.webkit.org/pipermail/webkit-dev/2010-May/012876.html In fairness, this comment https://lists.webkit.org/pipermail/webkit-dev/2010-May/012881.html seemed to suggest a lot more modest use of explicit.
David Levin
Comment 4 2010-09-28 11:59:58 PDT
Comment on attachment 68987 [details] Patch Withdrawn for now.
Note You need to log in before you can comment on or make changes to this bug.