| Summary: | [chromium] fix detection of missing fonts on DRT | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> | ||||
| Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | evan, tkent | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Tony Chang
2010-09-27 14:15:10 PDT
Created attachment 68956 [details]
Patch
This doesn't impact the tests running, but it makes the error message less confusing. LGTM Comment on attachment 68956 [details]
Patch
I'm reluctant to set cq+ on this because it is is a chromium gtk only change, and you can commit changes. The cq does not error catching for you here so setting cq+ just means that this may get landed when you aren't around and if it has problems, someone else has to work it out.
So I'll leave setting cq+ for you to do if/when you think it is prudent.
Comment on attachment 68956 [details]
Patch
No worries. I will land manually and watch the tree. I wasn't sure if the r+ would happen when I wasn't around.
Committed r68451: <http://trac.webkit.org/changeset/68451> |