Bug 46651 - [chromium] fix detection of missing fonts on DRT
Summary: [chromium] fix detection of missing fonts on DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-27 14:15 PDT by Tony Chang
Modified: 2010-09-27 17:06 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.46 KB, patch)
2010-09-27 14:18 PDT, Tony Chang 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-09-27 14:15:10 PDT 
[chromium] fix detection of missing fonts on DRT
Comment 1 Tony Chang 2010-09-27 14:18:09 PDT 
Created attachment 68956 [details]
Patch
Comment 2 Tony Chang 2010-09-27 14:26:16 PDT 
This doesn't impact the tests running, but it makes the error message less confusing.
Comment 3 Evan Martin 2010-09-27 15:39:02 PDT 
LGTM
Comment 4 David Levin 2010-09-27 16:50:04 PDT 
Comment on attachment 68956 [details]
Patch

I'm reluctant to set cq+ on this because it is is a chromium gtk only change, and you can commit changes. The cq does not error catching for you here so setting cq+ just means that this may get landed when you aren't around and if it has problems, someone else has to work it out.

So I'll leave setting cq+ for you to do if/when you think it is prudent.
Comment 5 Tony Chang 2010-09-27 16:54:33 PDT 
Comment on attachment 68956 [details]
Patch

No worries.  I will land manually and watch the tree.  I wasn't sure if the r+ would happen when I wasn't around.
Comment 6 Tony Chang 2010-09-27 17:06:30 PDT 
Committed r68451: <http://trac.webkit.org/changeset/68451>