Bug 46618

Summary: [Qt] : Enable local rendering on Maemo6
Product: WebKit Reporter: Girish Ramakrishnan <girish>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, webkit-ews, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Other   
Attachments:
Description Flags
Enable local rendering on Maemo6
none
Enable local rendering on Maemo6 take 2 tonikitoo: review+

Girish Ramakrishnan
Reported 2010-09-27 06:08:43 PDT
Enable local rendering on Maemo6.
Attachments
Enable local rendering on Maemo6 (7.77 KB, patch)
2010-09-27 06:11 PDT, Girish Ramakrishnan 		no flags
DetailsFormatted DiffDiff
Enable local rendering on Maemo6 take 2 (7.61 KB, patch)
2010-09-27 06:26 PDT, Girish Ramakrishnan 		tonikitoo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Girish Ramakrishnan
Comment 1 2010-09-27 06:11:40 PDT
Created attachment 68900 [details] Enable local rendering on Maemo6
WebKit Review Bot
Comment 2 2010-09-27 06:12:20 PDT
Attachment 68900 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/plugins/qt/PluginViewQt.cpp:77: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Girish Ramakrishnan
Comment 3 2010-09-27 06:26:27 PDT
Created attachment 68902 [details] Enable local rendering on Maemo6 take 2 Remove unnecessary include
Antonio Gomes
Comment 4 2010-09-27 06:36:57 PDT
Comment on attachment 68902 [details] Enable local rendering on Maemo6 take 2 You could had mentioned "plugins" in the description. Maybe "enable local rendering of plugins" or whatever more specific, since the changelog is not detailed.
Antonio Gomes
Comment 5 2010-09-27 06:37:15 PDT
Comment on attachment 68902 [details] Enable local rendering on Maemo6 take 2 I meant r+
Early Warning System Bot
Comment 6 2010-09-27 06:44:55 PDT
Attachment 68900 [details] did not build on qt: Build output: http://queues.webkit.org/results/4093082
Girish Ramakrishnan
Comment 7 2010-09-27 07:55:03 PDT
Landed in r68390
Ademar Reis
Comment 8 2010-09-27 11:36:56 PDT
Revision r68390 cherry-picked into qtwebkit-2.1 with commit eda6059 <http://gitorious.org/webkit/qtwebkit/commit/eda6059>
Note You need to log in before you can comment on or make changes to this bug.