Bug 46616

Summary: [Qt] 32-bit Flash crashes on repeated SetWindow calls
Product: WebKit Reporter: Andreas Kling <kling>
Component: Plug-insAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ademar, eric, kenneth, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   

Description Andreas Kling 2010-09-27 04:02:37 PDT
Re-enable PluginQuirkDontCallSetWindowMoreThanOnce for Qt on x86 Unix.

We incorrectly thought this was fixed in Flash 10, but it turns out it was just never broken on 64-bit.
Comment 1 Kenneth Rohde Christiansen 2010-09-27 04:06:30 PDT
rs=me!
Comment 2 Andreas Kling 2010-09-27 04:10:18 PDT
(In reply to comment #1)
> rs=me!

Dag nabbit, Kenneth, you are faster than speed itself! :O
Comment 3 Andreas Kling 2010-09-27 04:46:59 PDT
Landed in <http://trac.webkit.org/changeset/68381>
Comment 4 WebKit Review Bot 2010-09-27 06:15:33 PDT
http://trac.webkit.org/changeset/68381 might have broken Leopard Intel Release (Tests)
Comment 5 Ademar Reis 2010-10-21 14:16:10 PDT
I was about to cherry-pick the fix for bug 47545 and notice this one should be cherry-picked as well. It's a low risk change and will add consistency to our behavior regarding the flash plugin.
Comment 6 Ademar Reis 2010-10-22 05:37:42 PDT
Revision r68381 cherry-picked into qtwebkit-2.1 with commit 1994999 <http://gitorious.org/webkit/qtwebkit/commit/1994999>