Bug 46605

Summary: Add method which checks if a WebAccessibilityObject is in the cache.
Product: WebKit Reporter: Chris Guillory <ctguil>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cfleizach, commit-queue, dglazkov, dmazzoni, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Add WebAccessibilityCache::isCached
none
Add WebAccessibilityCache:getId
none
Add WebAccessibilityCache:getId - Now compiles dglazkov: review-, dglazkov: commit-queue-

Chris Guillory
Reported 2010-09-26 20:46:53 PDT
In chromium notifications code we need a way to determine if our WebAccessibilityCache currently contains a mapping for a WebAccessibilityObject. This will help to resolve a Chromium bug. http://code.google.com/p/chromium/issues/detail?id=46209
Attachments
Add WebAccessibilityCache::isCached (2.52 KB, patch)
2010-09-26 20:56 PDT, Chris Guillory 		no flags
DetailsFormatted DiffDiff
Add WebAccessibilityCache:getId (2.53 KB, patch)
2010-09-28 12:36 PDT, Chris Guillory 		no flags
DetailsFormatted DiffDiff
Add WebAccessibilityCache:getId - Now compiles (2.53 KB, patch)
2010-09-28 14:58 PDT, Chris Guillory 		dglazkov: review-
dglazkov: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Guillory
Comment 1 2010-09-26 20:56:13 PDT
Created attachment 68875 [details] Add WebAccessibilityCache::isCached
Adam Barth
Comment 2 2010-09-26 20:59:56 PDT
+fishd for Chromium API change.
Dimitri Glazkov (Google)
Comment 3 2010-09-27 07:19:10 PDT
Comment on attachment 68875 [details] Add WebAccessibilityCache::isCached What's the wider context of the change here? I really think we should keep caching invisible to the embedding layer.
Chris Guillory
Comment 4 2010-09-27 09:37:49 PDT
This is for an issue in Chromium. http://code.google.com/p/chromium/issues/detail?id=46209 Within the renderer WebAccessibilityObject instances are added to WebAccessibilityCacheImpl's cache before they are sent to the browser. The issue is that the browser cannot process a notification for a WebAccessibilityObject that isn't in this cache. AXObjectCache has // to be used with render objects AccessibilityObject* getOrCreate(RenderObject*); // will only return the AccessibilityObject if it already exists AccessibilityObject* get(RenderObject*); This is an attempt to add a method similar to AXObjectCache::get.
Chris Guillory
Comment 5 2010-09-28 12:36:31 PDT
Created attachment 69087 [details] Add WebAccessibilityCache:getId How about I add the method as getId. It will return invalidId when the WebAccessibilityCache doesn't have an id mapping for the AccessibilityObject.
WebKit Review Bot
Comment 6 2010-09-28 13:37:29 PDT
Attachment 69087 [details] did not build on chromium: Build output: http://queues.webkit.org/results/4165003
Chris Guillory
Comment 7 2010-09-28 14:58:44 PDT
Created attachment 69113 [details] Add WebAccessibilityCache:getId - Now compiles Corrected return type in header.
Dimitri Glazkov (Google)
Comment 8 2010-09-29 09:32:27 PDT
Comment on attachment 69113 [details] Add WebAccessibilityCache:getId - Now compiles I neglected to see that this is dealing with our WebKit-layer cache, not AXObjectCache. Thus I (and Darin) like the initial version of the patch.
WebKit Commit Bot
Comment 9 2010-09-29 10:20:03 PDT
Comment on attachment 68875 [details] Add WebAccessibilityCache::isCached Clearing flags on attachment: 68875 Committed r68658: <http://trac.webkit.org/changeset/68658>
WebKit Commit Bot
Comment 10 2010-09-29 10:20:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.