Bug 46548

Summary: [Qt] GraphicsContext::setLineDash() should scale dashOffset to penWidth
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ariya.hidayat, eric, rhodovan.u-szeged, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.carto.net/svg/samples/animated_bustrack.shtml
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2010-09-24 20:12:38 PDT
Qt's setLineDash() currently scales the dash array to the painter's penWidth, but not the dashOffset. This causes incorrect rendering of http://www.carto.net/svg/samples/animated_bustrack.shtml The problem is also exposed by (at least) one in-tree layout test: - svg/custom/js-repaint-rect-on-path-with-stroke.svg
Attachments
Proposed patch (1.35 KB, patch)
2010-09-24 20:16 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-09-24 20:16:25 PDT
Created attachment 68805 [details] Proposed patch
Andreas Kling
Comment 2 2010-09-25 08:44:26 PDT
Comment on attachment 68805 [details] Proposed patch Clearing flags on attachment: 68805 Committed r68331: <http://trac.webkit.org/changeset/68331>
Andreas Kling
Comment 3 2010-09-25 08:44:35 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2010-09-25 09:10:39 PDT
http://trac.webkit.org/changeset/68331 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/68329 http://trac.webkit.org/changeset/68330 http://trac.webkit.org/changeset/68331
Andreas Kling
Comment 5 2010-09-25 09:25:28 PDT
(In reply to comment #4) > http://trac.webkit.org/changeset/68331 might have totally b0rken Qt Linux Release Fixed with <http://trac.webkit.org/changeset/68332> :)
Note You need to log in before you can comment on or make changes to this bug.