Summary: | Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:] | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit-ews, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2010-09-24 18:22:52 PDT
Created attachment 68797 [details]
Patch
Attachment 68797 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/API/C/WKPage.h:167: Extra space between WKPageMouseDidMoveOverElementCallback and mouseDidMoveOverElement [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:132: Extra space between WKBundlePageMouseDidMoveOverElementCallback and mouseDidMoveOverElement [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:55: More than one command on the same line [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:64: More than one command on the same line [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:68: More than one command on the same line [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 8 in 27 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 68797 [details] did not build on qt: Build output: http://queues.webkit.org/results/4033141 Fixed Qt build locally. Comment on attachment 68797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68797&action=review Looks like you broke Qt. If you deal with that, r=me. > WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:43 > + RefPtr<InjectedBundleNodeHandle> nodeHandle = toWK(hitTestResultRef)->nodeHandle(); > + return toRef(nodeHandle.get()); Do you need a local variable here? Landed in http://trac.webkit.org/changeset/68322. |