Bug 46533

Summary: Add HighPass2FilterNode files
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, dglazkov, eric.carlson, jamesr, jer.noble, kbr, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Rogers 2010-09-24 15:40:54 PDT 
Add HighPass2FilterNode files
Comment 1 Chris Rogers 2010-09-24 15:41:51 PDT 
Created attachment 68775 [details]
Patch
Comment 2 Chris Rogers 2010-10-04 14:52:13 PDT 
Created attachment 69691 [details]
Patch
Comment 3 Chris Rogers 2010-10-04 14:53:32 PDT 
Fixed license and added FIXME in .idl about moving to BiquadNode.
Comment 4 Kenneth Russell 2010-10-04 15:00:28 PDT 
Comment on attachment 69691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69691&action=review

> WebCore/webaudio/HighPass2FilterNode.cpp:38
> +    m_processor = biquadProcessor.release();

Please see LowPass2FilterNode for request about the disposition of the m_biquadProcessor member.
Comment 5 Chris Rogers 2010-10-04 15:29:05 PDT 
Created attachment 69699 [details]
Patch
Comment 6 Chris Rogers 2010-10-04 15:30:20 PDT 
FIXED: Addressed comments about m_biquadProcessor as in LowPass2FilterNode.
Comment 7 Kenneth Russell 2010-10-04 15:50:01 PDT 
Comment on attachment 69699 [details]
Patch

Looks good to me.
Comment 8 WebKit Commit Bot 2010-10-05 00:33:28 PDT 
Comment on attachment 69699 [details]
Patch

Clearing flags on attachment: 69699

Committed r69088: <http://trac.webkit.org/changeset/69088>
Comment 9 WebKit Commit Bot 2010-10-05 00:33:35 PDT 
All reviewed patches have been landed.  Closing bug.