Summary: | Add HighPass2FilterNode files | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Rogers <crogers> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cmarrin, commit-queue, dglazkov, eric.carlson, jamesr, jer.noble, kbr, simon.fraser | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Chris Rogers
2010-09-24 15:40:54 PDT
Created attachment 68775 [details]
Patch
Created attachment 69691 [details]
Patch
Fixed license and added FIXME in .idl about moving to BiquadNode. Comment on attachment 69691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69691&action=review > WebCore/webaudio/HighPass2FilterNode.cpp:38 > + m_processor = biquadProcessor.release(); Please see LowPass2FilterNode for request about the disposition of the m_biquadProcessor member. Created attachment 69699 [details]
Patch
FIXED: Addressed comments about m_biquadProcessor as in LowPass2FilterNode. Comment on attachment 69699 [details]
Patch
Looks good to me.
Comment on attachment 69699 [details] Patch Clearing flags on attachment: 69699 Committed r69088: <http://trac.webkit.org/changeset/69088> All reviewed patches have been landed. Closing bug. |