Summary: | REGRESSION (r68054): Buttons no longer render at correct sizes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> | ||||
Component: | Forms | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ap, darin, eric, mitz, mrowe, webkit.review.bot | ||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
URL: | data:text/html,%3Cinput%20type=%22submit%22%3E%20%3Cinput%20type=%22submit%22%20style=%22font-size:%2010px%22%3E | ||||||
Attachments: |
|
Description
Mark Rowe (bdash)
2010-09-24 14:23:22 PDT
One thing I noticed in http://trac.webkit.org/changeset/68054 is that I got the logic backwards in this expression: "((states & DefaultState) ? nonDefaultButton : defaultButton)". But I don’t see anything else yet. Created attachment 68994 [details]
Patch
Committed r68459: <http://trac.webkit.org/changeset/68459> http://trac.webkit.org/changeset/68459 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release The following changes are on the blame list: http://trac.webkit.org/changeset/68459 http://trac.webkit.org/changeset/68460 |