Summary: | Add AudioBasicProcessorNode files | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Rogers <crogers> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cmarrin, commit-queue, dglazkov, eric.carlson, eric, jamesr, jer.noble, kbr, simon.fraser | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Chris Rogers
2010-09-24 12:16:33 PDT
Created attachment 68728 [details]
Patch
Created attachment 69520 [details]
Patch
Comment on attachment 69520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69520&action=review This basically looks good; couple of tiny changes. r- for the license text update discussed offline. > WebCore/webaudio/AudioBasicProcessorNode.cpp:44 > + , m_processor(0) m_processor does not require explicit initialization. > WebCore/webaudio/AudioBasicProcessorNode.cpp:85 > + // FIXME: if we take "tailTime" into account, then we can avoid calling processor()->process() once the tail dies down. Is tailTime concretely defined somewhere? If so, please mention where in the comment; otherwise, change to "tail time". Created attachment 69704 [details]
Patch
license updated and comments addressed. Comment on attachment 69704 [details]
Patch
Looks good to me.
Comment on attachment 69704 [details] Patch Rejecting patch 69704 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 69704]" exit_code: 2 Last 500 characters of output: 69704 from bug 46495. Parsing ChangeLog: /Projects/CommitQueue/WebCore/ChangeLog Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/webaudio/AudioBasicProcessorNode.cpp A WebCore/webaudio/AudioBasicProcessorNode.h Merge conflict during commit: Conflict at '/trunk/WebCore/ChangeLog' at /usr/local/git/libexec/git-core/git-svn line 572 Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Full output: http://queues.webkit.org/results/4220074 Comment on attachment 69704 [details]
Patch
That should have generated a retry.
Comment on attachment 69704 [details] Patch Clearing flags on attachment: 69704 Committed r69131: <http://trac.webkit.org/changeset/69131> All reviewed patches have been landed. Closing bug. (In reply to comment #8) > (From update of attachment 69704 [details]) > That should have generated a retry. I don't think we detect that case. It's not a "Checkout out of date" error. It's a merge failure. |