Bug 46479

Summary: Remove dead code and fix header includes in ResourceHandleWin
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, bweinstein, caseq, commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 43712    
Attachments:
Description Flags
Patch
none
Patch none

Patrick R. Gansterer
Reported 2010-09-24 10:21:00 PDT
see patch THE LAST ONE!!! \O/
Attachments
Patch (14.77 KB, patch)
2010-09-24 10:24 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (14.83 KB, patch)
2010-09-24 10:31 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-09-24 10:24:47 PDT
Created attachment 68705 [details] Patch
Darin Adler
Comment 2 2010-09-24 10:27:22 PDT
Comment on attachment 68705 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68705&action=review > WebCore/ChangeLog:5 > + Remove dead code and fix headser includes in ResourceHandleWin Typo: "headser". > WebCore/platform/network/ResourceHandleInternal.h:100 > + , m_loadSynchronously(false) Why are you adding this? Adding a new data member does not match up with your description of this patch.
Patrick R. Gansterer
Comment 3 2010-09-24 10:31:32 PDT
Created attachment 68706 [details] Patch
Adam Barth
Comment 4 2010-09-26 22:08:15 PDT
Comment on attachment 68706 [details] Patch Nice.
WebKit Commit Bot
Comment 5 2010-09-26 23:05:18 PDT
Comment on attachment 68706 [details] Patch Clearing flags on attachment: 68706 Committed r68371: <http://trac.webkit.org/changeset/68371>
WebKit Commit Bot
Comment 6 2010-09-26 23:05:23 PDT
All reviewed patches have been landed. Closing bug.
Andrey Kosyakov
Comment 7 2010-09-27 08:00:34 PDT
JFYI, this broke the build. Bots were fine though, apparently due to stale copy of ResourceHandleWin.h under WebKitBuild/include. Fixed at r68384.
Eric Seidel (no email)
Comment 8 2010-09-27 11:02:40 PDT
Is this then indicative of a build system bug for Windows which needs to be filed?
Andrey Kosyakov
Comment 9 2010-09-27 11:42:20 PDT
(In reply to comment #8) > Is this then indicative of a build system bug for Windows which needs to be filed? Filed as https://bugs.webkit.org/show_bug.cgi?id=46479
Andrey Kosyakov
Comment 10 2010-09-27 11:42:52 PDT
(In reply to comment #9) > (In reply to comment #8) > > Is this then indicative of a build system bug for Windows which needs to be filed? > > Filed as https://bugs.webkit.org/show_bug.cgi?id=46479 Sorry, typo. Filed as https://bugs.webkit.org/show_bug.cgi?id=46638
Note You need to log in before you can comment on or make changes to this bug.