| Summary: | [Chromium] Split webcore_html off webcore_remaining | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Marc-Antoine Ruel <maruel> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dglazkov, tkent, tony | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Marc-Antoine Ruel
2010-09-23 20:51:26 PDT
Created attachment 68643 [details]
Patch
Comment on attachment 68643 [details]
Patch
I take it the html directory has the most files?
Comment on attachment 68643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68643&action=review > WebCore/WebCore.gyp/WebCore.gyp:1219 > - ['exclude', '(android|cairo|cf|cg|curl|gtk|haiku|linux|mac|opentype|platform|posix|qt|soup|svg|symbian|win|wx)/'], > + ['exclude', '(android|cairo|cf|cg|curl|gtk|haiku|html|linux|mac|opentype|platform|posix|qt|soup|svg|symbian|win|wx)/'], Nit: It might be a bit clearer to put html in a separate line with a comment about webcore_html. There's rendering (135mb of .o) which will be the next one. There's bindings at 108mb but I'm not sure about the build ordering. For having html on its own line, I did the same for svg and integrated it in the big line. (In reply to comment #4) > For having html on its own line, I did the same for svg and integrated it in the big line. The comment is a bit confusing, but it's not a big deal either way. The patch is broken on Windows, will update. Please do not commit. Oh, the windows breakage was a fluke, the patch is good after all. Can someone c+ it? Comment on attachment 68643 [details] Patch Clearing flags on attachment: 68643 Committed r68615: <http://trac.webkit.org/changeset/68615> All reviewed patches have been landed. Closing bug. |