Bug 46434

Summary: DOMWindow::revokeBlobURL erroneously uses ParsedURLString
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: DOMAssignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: jianli
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 42959    
Attachments:
Description Flags
Proposed Patch ap: review+, jianli: commit-queue-

Alexey Proskuryakov
Reported 2010-09-23 17:24:06 PDT
The argument comes from the caller, there is absolutely no guarantee that it's in the form KURL expects. This causes assertion failures whenever it's not (e.g. revokeBlobURL("[foo bar]"); For absolute URLs, we should just pass a null base: KURL(KURL(), string). But if it can be relative, a proper base should be passed.
Attachments
Proposed Patch (6.19 KB, patch)
2010-09-23 18:20 PDT, Jian Li 		ap: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2010-09-23 18:20:50 PDT
Created attachment 68635 [details] Proposed Patch
Jian Li
Comment 2 2010-09-24 11:04:00 PDT
Committed as http://trac.webkit.org/changeset/68275.
Note You need to log in before you can comment on or make changes to this bug.