Bug 46425 – Add PluginProcessConnection and PluginProcessConnectionManager

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Add PluginProcessConnection and PluginProcessConnectionManager

[Anders Carlsson]

Created attachment 68615 [details]
Patch

[WebKit Review Bot]

Attachment 68615 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/PluginProcessConnectionManager.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 68615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68615&action=review

> WebKit2/WebProcess/Plugins/PluginProcessConnection.h:67
> +    // The CoreIPC connection.

I don't think this comment is adding anything.

> WebKit2/WebProcess/Plugins/PluginProcessConnectionManager.cpp:73
> +    }
> +
> +    CoreIPC::Connection::Identifier connectionIdentifier;
> +    CoreIPC::MachPort connectionMachPort;
> +    if (!WebProcess::shared().connection()->sendSync(WebProcessProxyMessage::GetPluginProcessConnection, 0,
> +                                                     CoreIPC::In(pluginPath),
> +                                                     CoreIPC::Out(connectionMachPort),
> +                                                     CoreIPC::Connection::NoTimeout))
> +        return 0;
> +
> +    connectionIdentifier = connectionMachPort.port();
> +    if (!connectionIdentifier)
> +        return 0;
> +

This looks very mac specific.  Should it be in a mac specific directory?


Otherwise looks good.

[Anders Carlsson]

Committed r68219: <http://trac.webkit.org/changeset/68219>