Summary: | Fix a condition check in ServerProcess, which becomes relevant when reading binary data. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
Component: | New Bugs | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, levin, tony | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Dimitri Glazkov (Google)
2010-09-23 14:18:55 PDT
Created attachment 68588 [details]
Patch
Is a test possible? not easily. this is embedded pretty close to some code reading directly off of sockets, and there's no easy way to mock it at the moment. I need to revamp this code in the next few days and I will be adding a lot more unit testing at that point. I stepped through this with dglazkov, and the bug is real and the fix is the right one. Comment on attachment 68588 [details] Patch Clearing flags on attachment: 68588 Committed r68201: <http://trac.webkit.org/changeset/68201> All reviewed patches have been landed. Closing bug. |