Bug 46402

Summary: [Qt] QWebHapticFeedbackPlayer needs correct exposure through QWebKitPlatformPlugin
Product: WebKit Reporter: Ademar Reis <ademar>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 46345    
Attachments:
Description Flags
patch
none
patch #2 none

Description Ademar Reis 2010-09-23 13:24:45 PDT 
QWebHapticFeedbackPlayer is exported through QWebKitPlatformPlugin::createExtension(), which returns QObject *.
(WebKit/qt/Api/qwebkitplatformplugin.h)

Haptics support is limited in trunk. I'm not sure if we should remove or fix this code.
(nevertheless, it's needed on the qtwebit-2.1 branch)

Patch is on the way
Comment 1 Ademar Reis 2010-09-23 13:32:18 PDT 
Created attachment 68580 [details]
patch
Comment 2 Ademar Reis 2010-09-23 14:25:29 PDT 
Changing the title of the bug because there are other fixes necessary. The patch will be updated as well.
Comment 3 Ademar Reis 2010-09-23 14:32:54 PDT 
Created attachment 68591 [details]
patch #2
Comment 4 WebKit Commit Bot 2010-09-23 15:09:00 PDT 
Comment on attachment 68591 [details]
patch #2

Clearing flags on attachment: 68591

Committed r68204: <http://trac.webkit.org/changeset/68204>
Comment 5 WebKit Commit Bot 2010-09-23 15:09:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Ademar Reis 2010-09-23 15:16:34 PDT 
Revision r68204 cherry-picked into qtwebkit-2.1 with commit 005c88d <http://gitorious.org/webkit/qtwebkit/commit/005c88d>