Bug 46381

Summary:

make fast/events/standalone-image-drag-to-editable.html non-flakey

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, jparent, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	levin: review+, levin: commit-queue-

Tony Chang

Reported 2010-09-23 11:56:54 PDT

[chromium] make fast/events/standalone-image-drag-to-editable.html non-flakey

Attachments
Patch (21.28 KB, patch) 2010-09-23 12:00 PDT, Tony Chang	levin: review+ levin: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2010-09-23 12:00:09 PDT

Created attachment 68555 [details] Patch

Tony Chang

Comment 2 2010-09-23 12:04:50 PDT

Actually, this isn't chromium specific since this changes the test for all platforms.

David Levin

Comment 3 2010-09-23 15:01:34 PDT

Comment on attachment 68555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68555&action=review Just some minor fixes to do on landing. > LayoutTests/fast/events/resources/standalone-image-drag-to-editable-frame.html:10 > + layoutTestController.notifyDone(); if (window.layoutTestController) > LayoutTests/fast/events/resources/standalone-image-drag-to-editable-frame.html:13 > + layoutTestController.notifyDone(); if (window.layoutTestController)

Tony Chang

Comment 4 2010-09-23 16:36:13 PDT

Committed r68213: <http://trac.webkit.org/changeset/68213>

Tony Chang

Comment 5 2010-09-23 16:37:25 PDT

Thanks for the review. I added a check for window.layoutTestController to the beginning of the function before committing.

Note You need to log in before you can comment on or make changes to this bug.