Bug 46378

Summary: Rename width/height on line boxes to logicalWidth/logicalHeight.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch mitz: review+

Description Dave Hyatt 2010-09-23 11:36:45 PDT 
Rename width/height on line boxes to logicalWidth/logicalHeight.
Comment 1 Dave Hyatt 2010-09-23 11:38:38 PDT 
Created attachment 68552 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-23 11:45:26 PDT 
Attachment 68552 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/InlineTextBox.cpp:796:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineTextBox.cpp:972:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 2 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2010-09-23 12:18:42 PDT 
Fixed in r68177.