Bug 46360

Summary:

[WinCairo] Add Build Slave

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, mrowe, wsiegrist

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch to add the WinCairo builder to the hierarchy.	none
Updated version with missing scheduler entry.	none
Revised with 'wincairo' naming due to BuildBot syntax issues.	none

Brent Fulgham

Reported 2010-09-23 09:22:30 PDT

The attached patch adds a WinCairo build slave to the suite of build bots.

Attachments
Patch to add the WinCairo builder to the hierarchy. (2.30 KB, patch) 2010-09-23 09:51 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Updated version with missing scheduler entry. (3.17 KB, patch) 2010-09-27 11:58 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Revised with 'wincairo' naming due to BuildBot syntax issues. (5.43 KB, patch) 2010-09-28 14:42 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2010-09-23 09:51:58 PDT

Created attachment 68533 [details] Patch to add the WinCairo builder to the hierarchy.

Brent Fulgham

Comment 2 2010-09-27 11:58:06 PDT

Created attachment 68941 [details] Updated version with missing scheduler entry. After running a few tests with a simulated BuildMaster, I realized that the configuration won't work without a corresponding 'Scheduler' entry. So I've revised the patch with that missing component.

Brent Fulgham

Comment 3 2010-09-28 14:42:31 PDT

Created attachment 69107 [details] Revised with 'wincairo' naming due to BuildBot syntax issues. Using the original "cairo-win32" platform label seemed to cause some problems with BuildBot (it was stripping off the "-win32" suffix, and passing only "cairo" as the platform.) To be consistent with the port's name and general use, I changed the build-webkit configuration flag from "--cairo-win32" to "--wincairo".

Brent Fulgham

Comment 4 2010-09-29 10:54:06 PDT

Build bot now updates and runs correctly.

Martin Robinson

Comment 5 2010-09-29 17:07:37 PDT

Comment on attachment 69107 [details] Revised with 'wincairo' naming due to BuildBot syntax issues. Looks sane to me.

Eric Seidel (no email)

Comment 6 2010-09-29 20:23:11 PDT

Yeah, rs=me too.

Eric Seidel (no email)

Comment 7 2010-09-30 03:21:49 PDT

Comment on attachment 68941 [details] Updated version with missing scheduler entry. Cleared Mark Rowe's review+ from obsolete attachment 68941 [details] so that this bug does not appear in http://webkit.org/pending-commit.

Brent Fulgham

Comment 8 2010-09-30 09:05:18 PDT

Landed in http://trac.webkit.org/changeset/68744.

William Siegrist

Comment 9 2010-09-30 09:33:24 PDT

You had a syntax error in config.json, but I fixed it in 68791. Master restart started.

Note You need to log in before you can comment on or make changes to this bug.