Bug 46354

Summary: [EFL] Fix warnings during build
Product: WebKit Reporter: Lucas De Marchi <lucas.de.marchi>
Component: WebKit EFLAssignee: Lucas De Marchi <lucas.de.marchi>
Status: RESOLVED FIXED    
Severity: Normal CC: barbieri, kenneth, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Lucas De Marchi
Reported 2010-09-23 08:10:29 PDT
[EFL] Fix warnings during build
Attachments
Patch (3.96 KB, patch)
2010-09-23 08:14 PDT, Lucas De Marchi 		no flags
DetailsFormatted DiffDiff
Patch (3.98 KB, patch)
2010-09-23 09:29 PDT, Lucas De Marchi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lucas De Marchi
Comment 1 2010-09-23 08:14:24 PDT
Created attachment 68521 [details] Patch
WebKit Review Bot
Comment 2 2010-09-23 08:15:34 PDT
Attachment 68521 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/efl/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] WebKit/efl/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] WebKit/efl/ChangeLog:14: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Lucas De Marchi
Comment 3 2010-09-23 09:29:28 PDT
Created attachment 68528 [details] Patch New patch removing the tab characters
Csaba Osztrogonác
Comment 4 2010-09-23 09:52:20 PDT
Comment on attachment 68528 [details] Patch LGTM, r=me
Lucas De Marchi
Comment 5 2010-09-23 09:57:02 PDT
Comment on attachment 68528 [details] Patch Clearing flags on attachment: 68528 Committed r68154: <http://trac.webkit.org/changeset/68154>
Lucas De Marchi
Comment 6 2010-09-23 09:57:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.