Bug 46350

Summary:

IDBTransaction missing layout tests.

Product:

WebKit

Reporter:

Andrei Popescu <andreip>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

jorlow, jsbell

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	jorlow: review-

Description Andrei Popescu 2010-09-23 07:42:09 PDT

IDBTransaction missing layout tests.

Comment 1 Andrei Popescu 2010-09-23 07:47:49 PDT

Created attachment 68517 [details]
Patch

Comment 2 Jeremy Orlow 2010-09-23 08:12:42 PDT

Comment on attachment 68517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68517&action=review

> LayoutTests/storage/indexeddb/transaction-get.html:18
> +        debug("Accessing a committed transaction should throw");

This needs to log a failure.

Comment 3 Joshua Bell 2012-01-27 13:48:46 PST

Tests for these cases now exist in storage/indexeddb/transaction-basics.html:

    evalAndExpectException("index.openCursor()", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("index.openKeyCursor()", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("index.get(0)", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("index.getKey(0)", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("index.count()", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");

    evalAndExpectException("store.put(0, 0)", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("store.add(0, 0)", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("store.delete(0)", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("store.clear()", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("store.get(0)", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("store.openCursor()", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");

And storage/indexeddb/transaction-and-objectstore-calls.html:

    evalAndExpectException("trans.objectStore('store')", "webkitIDBDatabaseException.NOT_ALLOWED_ERR");
    evalAndExpectException("store.index('index')", "webkitIDBDatabaseException.NOT_ALLOWED_ERR");

No need to try and land this one.