Bug 46331

Summary: minor cleanup of rebaseline-chromium-webkit-tests and gpu test_expectations
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, levin, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review-

Dirk Pranke
Reported 2010-09-22 18:39:29 PDT
minor cleanup of rebaseline-chromium-webkit-tests and gpu test_expectations
Attachments
Patch (3.03 KB, patch)
2010-09-22 18:41 PDT, Dirk Pranke 		abarth: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-09-22 18:41:26 PDT
Created attachment 68491 [details] Patch
Adam Barth
Comment 2 2010-09-22 19:49:09 PDT
Comment on attachment 68491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68491&action=review This seems like patches. I'd just landed the test_expectation.txt part without review. > WebKitTools/ChangeLog:7 > + the tool to breat on a git checkout, but that needs to be tracked breat => break > WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:592 > - # self._scm.add(path) > + self._scm.add(path) Seems like we need a test for whatever this does.
Dirk Pranke
Comment 3 2010-09-22 20:11:08 PDT
I'll just fix the code over in https://bugs.webkit.org/show_bug.cgi?id=46332 and land the expectation change separately, then. I will add a test for that :)
Dirk Pranke
Comment 4 2010-09-23 14:56:27 PDT
Committed r68202: <http://trac.webkit.org/changeset/68202>
Note You need to log in before you can comment on or make changes to this bug.