Bug 46307

Summary: Create one time initialization block for WebView's initWithFrame
Product: WebKit Reporter: Matthew Delaney <mdelaney7>
Component: WebKit Misc.Assignee: Matthew Delaney <mdelaney7>
Status: RESOLVED FIXED    
Severity: Trivial CC: aroben, commit-queue
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on:    
Bug Blocks: 45362    
Attachments:
Description Flags
Patch
none
update per comments none

Matthew Delaney
Reported 2010-09-22 14:05:37 PDT
There is a block of one time initialization code in WebView.cpp's initWithFrame that doesn't need to to be run for each new WebView and could be wrapped in a one time run block.
Attachments
Patch (1.63 KB, patch)
2010-09-22 14:50 PDT, Matthew Delaney 		no flags
DetailsFormatted DiffDiff
update per comments (1.62 KB, patch)
2010-09-22 14:58 PDT, Matthew Delaney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matthew Delaney
Comment 1 2010-09-22 14:50:15 PDT
Created attachment 68446 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-09-22 14:53:06 PDT
Comment on attachment 68446 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68446&action=review > WebKit/win/WebView.cpp:2564 > + static bool didOneTimeInitialization = false; No need for the " = false". That happens automatically.
Matthew Delaney
Comment 3 2010-09-22 14:58:05 PDT
Created attachment 68447 [details] update per comments Addressed comment.
Adam Roben (:aroben)
Comment 4 2010-09-22 14:59:07 PDT
Comment on attachment 68447 [details] update per comments Going to wait for the EWS bot to look at this before I cq+ it.
Eric Seidel (no email)
Comment 5 2010-09-23 03:18:56 PDT
Comment on attachment 68446 [details] Patch Cleared Adam Roben's review+ from obsolete attachment 68446 [details] so that this bug does not appear in http://webkit.org/pending-commit.
WebKit Commit Bot
Comment 6 2010-09-23 06:37:13 PDT
Comment on attachment 68447 [details] update per comments Clearing flags on attachment: 68447 Committed r68133: <http://trac.webkit.org/changeset/68133>
WebKit Commit Bot
Comment 7 2010-09-23 06:37:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.