New review-page design doesn't include name of reviewer

• Component: Tools / Tests
• Status: RESOLVED FIXED

[John Sullivan]

Often I click a link to a bug review page that was sent in email (rather than following the link from the bug page itself). The first thing I do is check whether the patch has already been reviewed. If it has, I often want to know who supplied the r+ or r- for various reasons, one of them being that I am especially interested in reading comments from certain reviewers.

Unfortunately, the redesigned review-page has left this information out. I can scroll to the bottom to see whether or not the patch has been reviewed, but it doesn't display the name of the reviewer. Could this information be put back in there?

[Adam Roben (:aroben)]

(In reply to comment #0)
> I often want to know who supplied the r+ or r- for various reasons, one of them being that I am especially interested in reading comments from certain reviewers.

If the reviewer left any comments, you'll see them inline with the patch. But I agree it would still be nice to see the names next to the r+/-.

[Darin Adler]

I have noticed this many times in the past two days. Definitely worth fixing.

[John Sullivan]

I had forgotten that reviewer comments have names, so the sample reason for wanting this that I provided doesn't apply. But I also want this for other reasons; for example, I have a higher confidence in some reviewers than others, so I might want to re-review or not, depending on who the original reviewer was.

[Darin Adler]

I rarely remember to type “n” to see the reviewer comments. I just look at that plus and sit there wondering.

[Adam Barth]

This is easy to add.

[Adam Barth]

Created attachment 68498 [details]
Patch

[John Sullivan]

Comment on attachment 68498 [details]
Patch

Thanks Adam!

[Adam Barth]

Committed r68120: <http://trac.webkit.org/changeset/68120>