Bug 46244

Summary: [GTK] Fix transfer annotations for WebKitGTK+ static API
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
annotations.diff none

Description Xan Lopez 2010-09-22 00:00:00 PDT 
There's still a lot of warnings for the DOM bindings, and a bunch of warnings left here (mostly about the parameter being named differently in the comment and the function definition), but this fixes the bulk of them.
Comment 1 Xan Lopez 2010-09-22 00:02:03 PDT 
Created attachment 68342 [details]
annotations.diff
Comment 2 Martin Robinson 2010-09-22 07:30:24 PDT 
Comment on attachment 68342 [details]
annotations.diff

View in context: https://bugs.webkit.org/attachment.cgi?id=68342&action=review

Okay!

> WebKit/gtk/webkit/webkitwebdatasource.cpp:204
> + * not be freed or destroyed.  This will return %NULL of the

Could you please fix the typo before landing?

> WebKit/gtk/webkit/webkitwebview.cpp:3651
> + * Return value: (transfer none): the main #WebKitWebFrame for @webView, or %NULL

Might want to say what cases it returns NULL in.
Comment 3 Xan Lopez 2010-09-22 07:41:43 PDT 
Comment on attachment 68342 [details]
annotations.diff

Landed as r68040 with the requested changes.
Comment 4 Xan Lopez 2010-09-22 07:41:53 PDT 
Closing.