Summary: | [chromium] REGRESSION(r67905): DRT test shell ALWAYS crashes on Mac | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | HTML Editing | Assignee: | Dirk Pranke <dpranke> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Major | CC: | abarth, dpranke, eric, ojan, tkent, tony | ||||
Priority: | P1 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | OS X 10.6 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2010-09-21 16:35:29 PDT
The root cause seems to be http://trac.webkit.org/changeset/67905. Created attachment 68311 [details]
Patch
Committed r67993: <http://trac.webkit.org/changeset/67993> Comment on attachment 68311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68311&action=review Removing the review flag since this was checked in, however: > WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:418 > + driver_args.append('--pixel-tests' % image_path) This can't be right. Committed r67999: <http://trac.webkit.org/changeset/67999> (In reply to comment #4) > (From update of attachment 68311 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=68311&action=review > > Removing the review flag since this was checked in, however: > > > WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:418 > > + driver_args.append('--pixel-tests' % image_path) > > This can't be right. True, it wasn't :( |