Bug 46230 – [chromium] REGRESSION(r67905): DRT test shell ALWAYS crashes on Mac

• Component: HTML Editing
• Status: RESOLVED FIXED

[Ryosuke Niwa]

chromium DRT crashes for all tests on Mac with the error "--pixel-tests with --test-shell requires a file name."  See http://build.webkit.org/builders/Chromium%20Mac%20Release%20(Tests)/builds/2160/steps/layout-test/logs/stdio for how this bug is affecting the cr-mac bot.

[Ryosuke Niwa]

The root cause seems to be http://trac.webkit.org/changeset/67905.

[Dirk Pranke]

Created attachment 68311 [details]
Patch

[Dirk Pranke]

Committed r67993: <http://trac.webkit.org/changeset/67993>

[Tony Chang]

Comment on attachment 68311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68311&action=review

Removing the review flag since this was checked in, however:

> WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:418
> +                driver_args.append('--pixel-tests' % image_path)

This can't be right.

[Dirk Pranke]

Committed r67999: <http://trac.webkit.org/changeset/67999>

[Dirk Pranke]

(In reply to comment #4)
> (From update of attachment 68311 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68311&action=review
> 
> Removing the review flag since this was checked in, however:
> 
> > WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:418
> > +                driver_args.append('--pixel-tests' % image_path)
> 
> This can't be right.

True, it wasn't :(

[Dirk Pranke]

I think r67999 is the right fix. I will watch the bots to find out.