Bug 46230

Summary:

[chromium] REGRESSION(r67905): DRT test shell ALWAYS crashes on Mac

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Major

CC:

abarth, dpranke, eric, ojan, tkent, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.6

Attachments:

Description	Flags
Patch	none

Description Ryosuke Niwa 2010-09-21 16:35:29 PDT

chromium DRT crashes for all tests on Mac with the error "--pixel-tests with --test-shell requires a file name."  See http://build.webkit.org/builders/Chromium%20Mac%20Release%20(Tests)/builds/2160/steps/layout-test/logs/stdio for how this bug is affecting the cr-mac bot.

Comment 1 Ryosuke Niwa 2010-09-21 16:46:24 PDT

The root cause seems to be http://trac.webkit.org/changeset/67905.

Comment 2 Dirk Pranke 2010-09-21 17:04:46 PDT

Created attachment 68311 [details]
Patch

Comment 3 Dirk Pranke 2010-09-21 17:07:18 PDT

Committed r67993: <http://trac.webkit.org/changeset/67993>

Comment 4 Tony Chang 2010-09-21 17:12:42 PDT

Comment on attachment 68311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68311&action=review

Removing the review flag since this was checked in, however:

> WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:418
> +                driver_args.append('--pixel-tests' % image_path)

This can't be right.

Comment 5 Dirk Pranke 2010-09-21 17:33:22 PDT

Committed r67999: <http://trac.webkit.org/changeset/67999>

Comment 6 Dirk Pranke 2010-09-21 17:38:17 PDT

(In reply to comment #4)
> (From update of attachment 68311 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68311&action=review
> 
> Removing the review flag since this was checked in, however:
> 
> > WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:418
> > +                driver_args.append('--pixel-tests' % image_path)
> 
> This can't be right.

True, it wasn't :(

Comment 7 Dirk Pranke 2010-09-21 17:38:46 PDT

I think r67999 is the right fix. I will watch the bots to find out.