Bug 46226

Summary: -[WebView _scheduleCompositingLayerSync] should wake the run loop
Product: WebKit Reporter: Paul Knight <pknight>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pknight
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
suggested patch
simon.fraser: review+
Address feedback from Simon Fraser, add a period at the end of a comment. none

Paul Knight
Reported 2010-09-21 16:00:31 PDT
This is in Radar as <rdar://problem/8460238>. -[WebView _scheduleCompositingLayerSync] should ensure that the runloop is woken up if the RLO is already scheduled. Otherwise, layers might not get synced for a while until some other event wakes the run loop, causing rendering delays.
Attachments
suggested patch (1.58 KB, patch)
2010-09-21 16:34 PDT, Paul Knight 		simon.fraser: review+
DetailsFormatted DiffDiff
Address feedback from Simon Fraser, add a period at the end of a comment. (1.58 KB, patch)
2010-09-21 16:42 PDT, Paul Knight 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Paul Knight
Comment 1 2010-09-21 16:34:46 PDT
Created attachment 68304 [details] suggested patch
Simon Fraser (smfr)
Comment 2 2010-09-21 16:38:32 PDT
Comment on attachment 68304 [details] suggested patch View in context: https://bugs.webkit.org/attachment.cgi?id=68304&action=review > WebKit/mac/WebView/WebView.mm:5874 > + // Make sure we wake up the loop or the observer could be delayed until some other source fires Period at the end of the sentence please.
Paul Knight
Comment 3 2010-09-21 16:42:33 PDT
Created attachment 68306 [details] Address feedback from Simon Fraser, add a period at the end of a comment.
WebKit Commit Bot
Comment 4 2010-09-22 01:37:10 PDT
Comment on attachment 68306 [details] Address feedback from Simon Fraser, add a period at the end of a comment. Clearing flags on attachment: 68306 Committed r68028: <http://trac.webkit.org/changeset/68028>
WebKit Commit Bot
Comment 5 2010-09-22 01:37:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.