Bug 46205

Summary:

cleanup: removeInlineStyleFromElement and extractInlineStyleToPushDown should be merged

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

darin, enrica, ojan, tkent, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

27818

Attachments:

Description	Flags
Patch	tkent: review+

Description Ryosuke Niwa 2010-09-21 11:40:14 PDT

Since removeImplicitlyStyledElement already supports extraction of the existing style, we should extend the support to removeInlineStyleFromElement and removeCSSStyle so that extractInlineStyleToPushDown can be merged with removeInlineStyleFromElement.

Comment 1 Ryosuke Niwa 2010-09-21 11:51:46 PDT

Created attachment 68268 [details]
Patch

Comment 2 Kent Tamura 2010-09-21 18:59:39 PDT

Comment on attachment 68268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68268&action=review

> WebCore/ChangeLog:12
> +        (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added extractedStyle.

nit: extractedStyle -> extractedStyle parameter or extractedStyle argument

> WebCore/ChangeLog:13
> +        (WebCore::ApplyStyleCommand::removeCSSStyle): Added extractedStyle.

ditto.

Comment 3 Ryosuke Niwa 2010-09-21 22:36:57 PDT

Committed r68014: <http://trac.webkit.org/changeset/68014>