Bug 46199

Summary: [chromium] LayerRendererChromium::prepareToDrawLayers logic needs cleanup
Product: WebKit Reporter: Vangelis Kokkevis <vangelis>
Component: WebCore Misc.Assignee: Vangelis Kokkevis <vangelis>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, jamesr, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch
none
proposed patch - fixed some comments jamesr: review+

Description Vangelis Kokkevis 2010-09-21 10:26:10 PDT 
There are a couple of issues here:
1. When the window size changes the entire root layer texture must be updated.  There's no reason to perform scrolling operations there.
2. When the scroll offset is larger than the size of the page we shouldn't be doing the glCopyPixels as there's no useful pixels to copy from
3. It shouldn't call updateLayersRecursive as that method is actually called right before the layers are drawn in the drawLayers() method.
Comment 1 Vangelis Kokkevis 2010-09-21 12:10:01 PDT 
Created attachment 68272 [details]
proposed patch
Comment 2 Vangelis Kokkevis 2010-09-21 12:20:18 PDT 
Created attachment 68274 [details]
proposed patch - fixed some comments
Comment 3 James Robinson 2010-09-21 12:40:09 PDT 
Comment on attachment 68274 [details]
proposed patch - fixed some comments

Looks good
Comment 4 Vangelis Kokkevis 2010-09-21 12:49:18 PDT 
Committed r67977: <http://trac.webkit.org/changeset/67977>