Bug 46199

Summary: [chromium] LayerRendererChromium::prepareToDrawLayers logic needs cleanup
Product: WebKit Reporter: Vangelis Kokkevis <vangelis>
Component: WebCore Misc.Assignee: Vangelis Kokkevis <vangelis>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, jamesr, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch
none
proposed patch - fixed some comments jamesr: review+

Vangelis Kokkevis
Reported 2010-09-21 10:26:10 PDT
There are a couple of issues here: 1. When the window size changes the entire root layer texture must be updated. There's no reason to perform scrolling operations there. 2. When the scroll offset is larger than the size of the page we shouldn't be doing the glCopyPixels as there's no useful pixels to copy from 3. It shouldn't call updateLayersRecursive as that method is actually called right before the layers are drawn in the drawLayers() method.
Attachments
proposed patch (5.11 KB, patch)
2010-09-21 12:10 PDT, Vangelis Kokkevis 		no flags
DetailsFormatted DiffDiff
proposed patch - fixed some comments (5.13 KB, patch)
2010-09-21 12:20 PDT, Vangelis Kokkevis 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vangelis Kokkevis
Comment 1 2010-09-21 12:10:01 PDT
Created attachment 68272 [details] proposed patch
Vangelis Kokkevis
Comment 2 2010-09-21 12:20:18 PDT
Created attachment 68274 [details] proposed patch - fixed some comments
James Robinson
Comment 3 2010-09-21 12:40:09 PDT
Comment on attachment 68274 [details] proposed patch - fixed some comments Looks good
Vangelis Kokkevis
Comment 4 2010-09-21 12:49:18 PDT
Committed r67977: <http://trac.webkit.org/changeset/67977>
Note You need to log in before you can comment on or make changes to this bug.