Summary: | Make collapsed borders in tables work with different block flows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mitz | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 46417 | ||||||
Attachments: |
|
Description
Dave Hyatt
2010-09-21 09:13:42 PDT
Created attachment 72838 [details]
Patch
Comment on attachment 72838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72838&action=review r=me > WebCore/rendering/RenderTableCell.cpp:666 > +CollapsedBorderValue RenderTableCell::collapsedLeftBorder() const > +{ > + if (table()->style()->isHorizontalWritingMode()) > + return table()->style()->isLeftToRightDirection() ? collapsedStartBorder() : collapsedEndBorder(); > + return table()->style()->isFlippedBlocksWritingMode() ? collapsedAfterBorder() : collapsedBeforeBorder(); I would cache table()->style() in a local and then use it in the three places where you acccess it. Ditto for collapsedRight/Top/BottomBorder. > WebCore/rendering/RenderTableCell.cpp:743 > +int RenderTableCell::borderHalfRight(bool outer) const > +{ > + if (table()->style()->isHorizontalWritingMode()) > + return table()->style()->isLeftToRightDirection() ? borderHalfEnd(outer) : borderHalfStart(outer); > + return table()->style()->isFlippedBlocksWritingMode() ? borderHalfBefore(outer) : borderHalfAfter(outer); Same comment. Cache table()->style() in a local. Same for all of the borderHalf*** functions. |