Bug 46188

Summary: Make the cross-platform setPrinting method match the Mac-specific WebKit method.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: PrintingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sullivan: review+

Dave Hyatt
Reported 2010-09-21 08:52:53 PDT
OS X does not use Frame::setPrinting, since it still has its own WebKit method. The cross-platform method was copied from it, and I noticed while mucking around in the printing code that it contains an error. Subframes are not supposed to receive the page size or lay out to the page size. The Mac method just passes 0 for all the numbers to child frames, so I will change the cross-platform method to match.
Attachments
Patch (1.43 KB, patch)
2010-09-21 08:54 PDT, Dave Hyatt 		sullivan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-09-21 08:54:38 PDT
Created attachment 68244 [details] Patch
Dave Hyatt
Comment 2 2010-09-21 08:58:37 PDT
Fixed in r67956.
Note You need to log in before you can comment on or make changes to this bug.