Summary: | [WIN] Add internetHandle to WebCoreSynchronousLoader. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||
Component: | Platform | Assignee: | Patrick R. Gansterer <paroga> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aroben, commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 43712 | ||||||||
Attachments: |
|
Description
Patrick R. Gansterer
2010-09-21 07:21:24 PDT
Created attachment 68237 [details]
Patch
Comment on attachment 68237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68237&action=review > WebCore/platform/network/win/ResourceHandleWin.cpp:87 > +static HINTERNET asynchronousInternetHandle(const String& userAgent) > +{ > + static HINTERNET internetHandle = 0; > + > + if (!internetHandle) > + internetHandle = createInternetHandle(userAgent, true); > + > + return internetHandle; > +} You can do this more simply: static HINTERNET internetHandle = createInternetHandle(userAgent, true); return internetHandle; > WebCore/platform/network/win/ResourceHandleWin.cpp:188 > , m_response(response) > , m_data(data) > { > + m_internetHandle = createInternetHandle(userAgent, false); > +} Why not put this in the initializer list? Created attachment 68245 [details]
Patch
Comment on attachment 68245 [details] Patch Clearing flags on attachment: 68245 Committed r68020: <http://trac.webkit.org/changeset/68020> All reviewed patches have been landed. Closing bug. |