Bug 46185 – [WIN] Add internetHandle to WebCoreSynchronousLoader.

• Component: Platform
• Status: RESOLVED FIXED

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 68237 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 68237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68237&action=review

> WebCore/platform/network/win/ResourceHandleWin.cpp:87
> +static HINTERNET asynchronousInternetHandle(const String& userAgent)
> +{
> +    static HINTERNET internetHandle = 0;
> +
> +    if (!internetHandle)
> +        internetHandle = createInternetHandle(userAgent, true);
> +
> +    return internetHandle;
> +}

You can do this more simply:

static HINTERNET internetHandle = createInternetHandle(userAgent, true);
return internetHandle;

> WebCore/platform/network/win/ResourceHandleWin.cpp:188
>      , m_response(response)
>      , m_data(data)
>  {
> +    m_internetHandle = createInternetHandle(userAgent, false);
> +}

Why not put this in the initializer list?

[Patrick R. Gansterer]

Created attachment 68245 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 68245 [details]
Patch

Clearing flags on attachment: 68245

Committed r68020: <http://trac.webkit.org/changeset/68020>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.