Bug 46178

Summary: it's not possible to easily tell which part of the file name of an indexed db is the security origin
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, bulach, commit-queue, jorlow
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

jochen
Reported 2010-09-21 04:56:41 PDT
it's not possible to easily tell which part of the file name of an indexed db is the security origin
Attachments
Patch (1.56 KB, patch)
2010-09-21 05:00 PDT, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2010-09-21 05:00:04 PDT
Created attachment 68221 [details] Patch
Jeremy Orlow
Comment 2 2010-09-21 05:21:07 PDT
Comment on attachment 68221 [details] Patch r=me
Jeremy Orlow
Comment 3 2010-09-21 05:24:37 PDT
NOTE: this will cause a bunch of dead db files to stay around. Those could possibly cause parsing issues if we use securityOrigin::fromDatabaseIdentifier on these file names or something like that. It might be best for all indexed db developers to delete their indexedDB directory from chromium after syncing all clients past this. Otherwise it's quite possible you'll run into some odd/nasty errors in the future if any code does make assumptions about all the files in this dir. The other option is to, after this lands, change the directory we save IndexedDB stuff in...but I don't think that's necessary. Also, obviously any existing data in databases with the old name format will no longer be accessible...but I doubt anyone cares.
WebKit Commit Bot
Comment 4 2010-09-21 07:20:01 PDT
Comment on attachment 68221 [details] Patch Clearing flags on attachment: 68221 Committed r67950: <http://trac.webkit.org/changeset/67950>
WebKit Commit Bot
Comment 5 2010-09-21 07:20:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.