Bug 46177

Summary: Make FilterEffects independent of SVG
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit-ews, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 68469, 26389    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Dirk Schulze 2010-09-21 04:50:54 PDT 
Make FilterEffects independent of SVG
Comment 1 Dirk Schulze 2010-09-21 04:58:25 PDT 
Created attachment 68220 [details]
Patch
Comment 2 Dirk Schulze 2010-09-21 04:59:08 PDT 
(In reply to comment #1)
> Created an attachment (id=68220) [details]
> Patch

Just Mac is missing, since I can't update Xcode from here.
Comment 3 Nikolas Zimmermann 2010-09-21 05:13:06 PDT 
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=68220) [details] [details]
> > Patch
> 
> Just Mac is missing, since I can't update Xcode from here.

Isn't it possible to manually move them, by just editing the file?;
The UUID stays the same, you should just have to reorder them.
Comment 4 Early Warning System Bot 2010-09-21 05:15:54 PDT 
Attachment 68220 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3999077
Comment 5 Dirk Schulze 2010-09-21 05:22:59 PDT 
Created attachment 68222 [details]
Patch
Comment 6 Eric Seidel (no email) 2010-09-21 05:32:47 PDT 
Attachment 68220 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4049096
Comment 7 Dirk Schulze 2010-09-21 05:42:12 PDT 
Created attachment 68224 [details]
Patch
Comment 8 Dirk Schulze 2010-09-21 05:42:49 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Created an attachment (id=68220) [details] [details] [details]
> > > Patch
> > 
> > Just Mac is missing, since I can't update Xcode from here.
> 
> Isn't it possible to manually move them, by just editing the file?;
> The UUID stays the same, you should just have to reorder them.

Tried it with the last patch. Let's see if I got it to work.
Comment 9 Eric Seidel (no email) 2010-09-21 05:43:19 PDT 
Attachment 68222 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4026090
Comment 10 Eric Seidel (no email) 2010-09-21 05:57:38 PDT 
Attachment 68224 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4098015
Comment 11 Dirk Schulze 2010-09-21 07:33:03 PDT 
Created attachment 68239 [details]
Patch
Comment 12 Dirk Schulze 2010-09-21 07:38:59 PDT 
Modified the project file with Xcode this time. Hopefully it builds now. Didn't test it on my local machine.
Comment 13 Dirk Schulze 2010-09-21 22:20:49 PDT 
Not sure why the ews bot for win has problems. I updated to trunk and had no problems applying this patch.
Comment 14 Dirk Schulze 2010-09-21 23:46:16 PDT 
Uploading the same patch again to restart Win EWS.
Comment 15 Dirk Schulze 2010-09-21 23:47:20 PDT 
Created attachment 68341 [details]
Patch
Comment 16 Nikolas Zimmermann 2010-09-22 00:12:52 PDT 
Comment on attachment 68341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68341&action=review

> WebCore/ChangeLog:16
> +        * WebCore.vcproj/WebCore.vcproj:

WebCore.xcodeproj not listed here.

Even if we don't know if win builds, EWS is taking just too long. Just try landing.
Comment 17 Dirk Schulze 2010-09-22 00:42:37 PDT 
Committed r68022: <http://trac.webkit.org/changeset/68022>
Comment 18 Dirk Schulze 2010-10-04 01:35:59 PDT 
Comment on attachment 68341 [details]
Patch

Already committed. Clearing r-flag.