Bug 46172

Summary: [Qt] Add robot loader timeout and extra time options.
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: New BugsAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ademar
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch kling: review+, kling: commit-queue-

Jocelyn Turcotte
Reported 2010-09-21 03:37:06 PDT
[Qt] Add robot loader timeout and extra time options.
Attachments
Patch (6.90 KB, patch)
2010-09-21 03:41 PDT, Jocelyn Turcotte 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2010-09-21 03:41:54 PDT
Created attachment 68208 [details] Patch
Jocelyn Turcotte
Comment 2 2010-09-21 03:44:23 PDT
These options are used to run stability tests on Symbian using QtTestBrowser. Right now the robot loader relies on the loadFinished signal to continue loading the URL list, however we have some load hangs on that platform that prevent us testing further to catch long term usage crashes.
Andreas Kling
Comment 3 2010-09-21 04:00:49 PDT
Comment on attachment 68208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68208&action=review > WebKitTools/QtTestBrowser/urlloader.cpp:50 > + } else { Coding style, should be "} else" r=me
Jocelyn Turcotte
Comment 4 2010-09-21 07:34:57 PDT
Committed r67942: <http://trac.webkit.org/changeset/67942>
Ademar Reis
Comment 5 2010-09-21 10:30:55 PDT
Revision r67942 cherry-picked into qtwebkit-2.1 with commit a47890e <http://gitorious.org/webkit/qtwebkit/commit/a47890e>
Note You need to log in before you can comment on or make changes to this bug.