Bug 46160

Summary: The tool member variable should be called _tool
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Adam Barth 2010-09-20 20:06:21 PDT 
The tool member variable should be called _tool
Comment 1 Adam Barth 2010-09-20 20:07:24 PDT 
Created attachment 68180 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-20 20:09:18 PDT 
Attachment 68180 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/Scripts/webkitpy/tool/multicommandtool.py:192:  at least two spaces before inline comment  [pep8/E261] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2010-09-20 20:24:26 PDT 
Comment on attachment 68180 [details]
Patch

Clearing flags on attachment: 68180

Committed r67916: <http://trac.webkit.org/changeset/67916>
Comment 4 WebKit Commit Bot 2010-09-20 20:24:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-09-20 21:00:37 PDT 
http://trac.webkit.org/changeset/67916 might have broken SnowLeopard Intel Release (Tests)